Add rename to apitype.UpdateKind. #3805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkisk
added
the
impact/no-changelog-required
chrsmith
approved these changes
Jan 27, 2020
pkg/apitype/history.go
Outdated
| @@ -29,6 +29,8 @@ const ( | |||
| PreviewUpdate UpdateKind = "preview" | |||
| // RefreshUpdate is an update that came from a refresh operation. | |||
| RefreshUpdate UpdateKind = "refresh" | |||
| // RenameUpdate is an update that changes the name of a Pulumi program. | |||
There was a problem hiding this comment.
Looks good, but to be super clear, we should probably say "changes the stack name or project name of a Pulumi program." (As "name" could be ambiguous.)
jkisk
force-pushed
the
jkinkead/updatekind-rename
branch
from
ef216cd
to
9b8cab7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses issue #3785