Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make primitive input types implement pointer types #3806

Merged
merged 2 commits into from
Jan 25, 2020
Merged

Conversation

pgavlin
Copy link
Member

@pgavlin pgavlin commented Jan 25, 2020

For example, pulumi.String also implements pulumi.StringPtr. This is
consistent with the output of the code generator, and makes optional
inputs much more ergonomic.

For example, pulumi.String also implements pulumi.StringPtr. This is
consistent with the output of the code generator, and makes optional
inputs much more ergonomic.
@pgavlin
Copy link
Member Author

pgavlin commented Jan 25, 2020

I'm going to go ahead and merge this so I can get it out with 1.9.1 this weekend. Please leave any feedback and I'll be happy to address it after the fact.

@pgavlin pgavlin merged commit 47b7eaf into master Jan 25, 2020
@pulumi-bot pulumi-bot deleted the pgavlin/goPtrInputs branch January 25, 2020 20:19
Copy link
Contributor

@EvanBoyle EvanBoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants