Add current operation info to stack command output. #3822
Conversation
jkisk
force-pushed
the
jkinkead/current-op
branch
from
af90cc2
to
34edd27
Compare
jkisk
changed the title
|
@jkisk Do you have an example of what this looks like that you could share? Should we include a link to the update in the console? |
|
I'm very open to feedback on how this should be formatted, or if we should add a link to the update in the console.
|
There was a problem hiding this comment.
Thanks for attaching a screen shot.
Displaying both the "Last update" and "Operation in progress" data seems redundant. Perhaps we just show either "Last updated: ..." or "Update in progress: ..."
As far as the specific data you are displaying, I'd suggest against the phrase "operation in progress". As that doesn't sound super friendly. Also, what do you think about putting the start time first, as I imagine that's the most important piece of data someone wants to know. Finally, while wiring through the type of update being performed... I can't think of a natural way to mention that. e.g. "Update in progress: update" is super-confusing. So maybe we just don't display that information?
So putting that all together, I'd propose this alternative:
...
Managed by https://api.jamie.pulumi-dev.io
Owner: Kinkead
Update in progress:
Started: 5 seconds ago
Requested By: Kinkead
Pulumi version: ...
...
Also a big +1 to Luke's suggestion to add a permalink to the Pulumi console. Though I don't know if we have all the necessary data. (We might not have the version of the stack update in progress, which we'd need to link to it. Jamie, you can see callers of b.CloudConsoleURL for how we render these permalink elsewhere.)
| @@ -2,6 +2,8 @@ CHANGELOG | |||
| ========= | |||
|
|
|||
| ## HEAD (unreleased) | |||
| - Add information about an in-flight operation to the stack command output, if applicable. | |||
There was a problem hiding this comment.
As you can see from the other edits to the CHANGELOG.md file, it's useful to link to the bug that is being fixed so someone can drill into the specific item to learn more.
cmd/stack.go
Outdated
| @@ -69,6 +70,13 @@ func newStackCmd() *cobra.Command { | |||
| if isCloud { | |||
| if cs, ok := s.(httpstate.Stack); ok { | |||
| fmt.Printf(" Owner: %s\n", cs.OrgName()) | |||
| // If there is an in-flight operation, provide info. | |||
| if cs.CurrentOperation() != nil { | |||
There was a problem hiding this comment.
To avoid the redundant cs.CurrentOperation(), why don't we declare it as a new variable. Such as:
if currentOp := cs.CurrentOperation(); currentOp != nil {
fmt.Printf(" Operation in progress: %s\n", currentOp.Kind)
}IMHO, it is a lot easier to read that way.
jkisk
force-pushed
the
jkinkead/current-op
branch
from
34edd27
to
02265af
Compare
This will complete the process of wiring through current operation in progress info to the CLI, addressing issue #4468. If an update is currently in progress a "Last Updated" time won't be displayed.
Example: