Support stack references in Go SDK #3829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oStackReference
- ReadResource ought to just accept a StringInput - No custom state type is necessary for stack references--a properly-tagged struct type that embeds a CustomResourceState is sufficient - GetOutput should return an AnyOutput
pgavlin
requested changes
Feb 3, 2020
pgavlin
approved these changes
Feb 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2344
Tested locally via this test example: https://github.com/pulumi/examples/compare/evan/goStackRefVerification
Unsure of how to test this within our existing pulumi/pulumi framework. Suggestions welcome. Looks like other languages like python don't have coverage for this area.