Adds TPL based runTask to Deployment #3858
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @yreynhout I haven't looked at your PR before because it is marked as draft. Do you still want to do something here, or is it done? I think it's a useful change. |
|
Hi @mikhailshilkov - pretty much done from my point of view - just didn't know whether it was deemed a useful addition or not. Your call to be honest. |
|
Great! Do you mind rebasing on the latest and adding a short note to CHANGELOG.md? |
|
Sure, no problem |
yreynhout
force-pushed
the
deployment-runtask
branch
from
04612cb
to
ab843f8
Compare
|
@mikhailshilkov done. |
abhinav
pushed a commit
to pulumi/pulumi-dotnet
that referenced
this pull request
Jan 11, 2023
Add TPL based runTask to Deployment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not entirely sure how useful this is to have in the library, but it's something I keep embedding in my own codebase.