Add --version flag to 'pulumi stack export' #3906
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgavlin
approved these changes
Feb 11, 2020
pkg/backend/backend.go
Outdated
| @@ -189,6 +189,19 @@ type Backend interface { | |||
| CurrentUser() (string, error) | |||
| } | |||
|
|
|||
| // SpecificDeploymentExporter is an interface that extends Backend, which adds the ability to export | |||
There was a problem hiding this comment.
This doesn't need to extend Backend (it's generally idiomatic to keep interfaces as narrow as possible). LGTM otherwise.
pkg/backend/httpstate/backend.go
Outdated
| return b.exportDeployment(ctx, stack.Ref(), nil /* latest */) | ||
| } | ||
|
|
||
| func (b *cloudBackend) ExportSpecificDeployment( |
There was a problem hiding this comment.
Nit:
Suggested change
| func (b *cloudBackend) ExportSpecificDeployment( | |
| func (b *cloudBackend) ExportDeploymentForVersion( |
chrsmith
force-pushed
the
chrsmith/1910/export-older-versions
branch
from
f96dad8
to
7cf6e31
Compare
pgavlin
reviewed
Feb 13, 2020
| // SpecificDeploymentExporter is an interface defining an additional capability of a Backend, specifically the | ||
| // ability to export a specific versions of a stack's deployment. This isn't a requirement for all backends and | ||
| // should be checked for dynamically. | ||
| type SpecificDeploymentExporter interface { |
There was a problem hiding this comment.
Tiny nit for consistency with the method name
Suggested change
| type SpecificDeploymentExporter interface { | |
| type VersionedDeploymentExporter interface { |
pgavlin
approved these changes
Feb 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
--versionflag topulumi stack export, which will request that the backend export an older version of the checkpoint rather than whatever is the "latest".This is implemented not by adding a new method to the
backend.Backendinterface, since we don't necessarily want to require this capability for all backends. (And would also cause some problems, such as missing data, for thefilestatebackend.) So I went with an approach where we extend the interface, and dynamically check if the backend supportsSpecificDeploymentExporter. (If you are familiar with COM, this is kinda-sorta theIBackend2type pattern.Examples of common errors:
Fixes #1910