Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify resource options #3943

Merged
merged 2 commits into from
Feb 21, 2020
Merged

Conversation

mikhailshilkov
Copy link
Member

The major part of #3857
Makes ResourceOptions abstract to avoid confusing usage

@mikhailshilkov mikhailshilkov added impact/breaking Fixing this issue will require a breaking change language/dotnet labels Feb 20, 2020
@mikhailshilkov
Copy link
Member Author

Not sure who is my review buddy for .NET now, assigned to @lukehoban for now

Copy link
Member

@lukehoban lukehoban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mikhailshilkov mikhailshilkov merged commit 42d1a60 into master Feb 21, 2020
@pulumi-bot pulumi-bot deleted the mikhailshilkov/resource-options branch February 21, 2020 08:24
abhinav pushed a commit to pulumi/pulumi-dotnet that referenced this pull request Jan 11, 2023
Simplify resource options, making the base class abstract
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/breaking Fixing this issue will require a breaking change language/dotnet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants