-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow pulumi stack export to decrypt secrets #4046
Conversation
@lukehoban / @pgavlin would love eyes on this when you get some time please |
642140c
to
0ee1a5c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few notes. But would definitely be great for @pgavlin to take a look too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few things offhand--I'll take a more detailed look later today.
d252414
to
bd9c148
Compare
We're running into to this, the workaround to migrate a stack - we're going from default secret provider to kms- is very tedious without this. Any update? |
Hi @NinoFloris We paused this to concentrate on the 2.0 work so I will get back to this shortly Paul |
bd9c148
to
6829332
Compare
This allows to export and import secrets
I can see the secrets in the output as well:
|
6829332
to
ab6927f
Compare
97df22b
to
dc6f373
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
BTW - also confirmed that this works 😄:
$ pulumi stack init fromstack
$ pulumi config set aws:region us-west-2
$ pulumi up --skip-preview
$ pulumi stack init tostack
$ cp Pulumi.fromstack.yaml Pulumi.tostack.yaml
$ pulumi stack export --show-secrets -s fromstack | sed 's/fromstack/tostack/g' | pulumi stack import -s tostack
$ pulumi preview -s tostack
Previewing update (tostack):
Type Name Plan
pulumi:pulumi:Stack node14-tostack
Resources:
2 unchanged
dc6f373
to
afed769
Compare
Fixes: #2918 This allows us to run the command `pulumi stack export --show-secrets` it will also introduce the changes that allows the import to handle when plain text is included in the import file
afed769
to
c594957
Compare
Fixes: #2918
This allows us to run the command
pulumi stack export --show-secrets
it will also introduce the changes that allows the import to handle
when plain text is included in the import file