Go plugin acquisition #4060
Merged
Go plugin acquisition #4060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes implement `GetRequiredPlugins` for Go using a registry mechanism and an alternate entry point for `pulumi.Run`. Packages that require plugins are expected to register themselves with the Pulumi SDK. When `pulumi.Run` is used and the `PULUMI_PLUGINS` envvar is truthy, the program will dump a JSON-encoded description of its required plugins to stdout. The language host then uses this description to respond to `GetRequiredPlugins`. Fixes #1549.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revamping the reverted PR from here: #3830
It turns out that if we don't append existing environment variables in the
go runcase, the command fails with:The fact that the previous CI run from
f652d93passed is slightly concerning, as doing a pulumi up locally fails if I don't have the executable pre-buildgo build -o ....We should definitely make sure that we're testing the go run path in CI since we're finding discrepancies like this cc @stack72