Fix 'pulumi stack ls' on Windows #4094
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 for more Windows test coverage |
jkisk
approved these changes
Mar 18, 2020
| // view of file paths. Since it will assume that backslashes (file separators on Windows) are part of | ||
| // file names, and this causes "problems". | ||
| func TestWrappedBucket(t *testing.T) { | ||
| // wrappedBucket will only massage file paths IFF it is needed, as filepath.ToSlash is a noop. |
| // Perform basic file operations using wrappedBucket and verify that it will | ||
| // successfully handle both "/" and "\" as file separators. (And probably fail in | ||
| // exciting ways if you try to give it a file on a system that supports "\" or "/" as | ||
| // a valid character in a filename.) |
There was a problem hiding this comment.
Are there systems that do that? Just curious...
There was a problem hiding this comment.
Not to my knowledge.
| assert.False(t, exists, "Deleted file still found?") | ||
| }) | ||
|
|
||
| // Verify ListObjects / listBucket works with regard to differeing file separators too. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The command
pulumi stack lsdidn't work on Windows when using the local file backend. The reason boils down to theblob.Buckettype we use, to abstract file IO for the { local disk, Azure, GCP, S3, etc. }By design, it only supports forward slashes as directory separator characters. So we canonicalize file paths using
file path.ToSlashbefore we call its methods, using thewrappedBucketinterface.However, we missed the canonicalization for the data we pass to
ListObjects(...). Which was whypulumi stack lsdidn't work on Windows. (Butpulumi stackdid, because we use a different method, which does the path canonicalization.)This PR also runs the
pkg/backend/unit tests on Appveyor too, since previously we didn't have any Windows-coverage for these file bucket methods.Fixes #3504