Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add aliases to the Go SDK codegen pkg #4157

Merged
merged 2 commits into from
Mar 24, 2020
Merged

Add aliases to the Go SDK codegen pkg #4157

merged 2 commits into from
Mar 24, 2020

Conversation

lblackstone
Copy link
Member

@lblackstone lblackstone commented Mar 23, 2020 •
edited
Loading

Fixes #3884

Here's the resulting k8s SDK: pulumi/pulumi-kubernetes@aa199fe

lblackstone
lblackstone commented Mar 23, 2020
View reviewed changes
pkg/codegen/go/gen.go Outdated Show resolved Hide resolved
@lblackstone
Copy link
Member Author

I tested that this worked properly for a Deployment. Created an apps/v1beta1:Deployment and then updated to apps/v1:Deployment. The apiVersion was updated, but no replacement occurred.

EvanBoyle
EvanBoyle approved these changes Mar 24, 2020
View reviewed changes
Copy link
Contributor

@EvanBoyle EvanBoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@lblackstone lblackstone merged commit 8ce10e1 into master Mar 24, 2020
@pulumi-bot pulumi-bot deleted the lblackstone/go-codegen-aliases branch March 24, 2020 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EvanBoyle EvanBoyle EvanBoyle approved these changes

@pgavlin pgavlin Awaiting requested review from pgavlin

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add aliases to the go code generator
2 participants
@lblackstone @EvanBoyle