Enable features in mock monitor #4272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukehoban
approved these changes
Apr 2, 2020
lukehoban
reviewed
Apr 2, 2020
| @@ -4,6 +4,9 @@ CHANGELOG | |||
| ## HEAD (unreleased) | |||
| - Fix handling of `nil` values in Outputs in Go. | |||
| [#4268](https://github.com/pulumi/pulumi/pull/4268) | |||
|
|
|||
| - Fix handling of secret values in mock-based tests. | |||
| [#4272](https://github.com/pulumi/pulumi/pull/4272) | |||
There was a problem hiding this comment.
Do we have any tests that validate mocks working with secrets?
There was a problem hiding this comment.
I had the same question but it looks like we don't have any tests for mocks. Probably worth adding them for all languages / methods / parameter permutations, but sounds a bit out of the scope for this issue?
There was a problem hiding this comment.
We did add tests for Python mocks recently - #4074.
But happy to split out a new issue on getting test coverage broadly on mocking.
There was a problem hiding this comment.
Awesome! I missed that one. Now I augmented the Python test to use a secret. Also created #4276 to add tests for other runtimes.
mikhailshilkov
force-pushed
the
mikhailshilkov/mock-secrets
branch
from
32d5876
to
1de8782
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables secret support in mock-based tests. Go and C# seem to be fine as-is.
Fixes #4145