Propagate secretness correctly in Python apply
#4273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinvp
force-pushed
the
justin/python_secret
branch
from
7f102dc
to
3861404
Compare
justinvp
commented
Apr 2, 2020
| @@ -13,6 +13,7 @@ | |||
| # limitations under the License. | |||
There was a problem hiding this comment.
I added tests to this file as this is where some similar/related tests already were -- though, these new tests (and some of the existing ones) would prob make more sense in a new test_output.py.
pgavlin
approved these changes
Apr 2, 2020
abhinav
pushed a commit
to pulumi/pulumi-dotnet
that referenced
this pull request
Jan 11, 2023
* Propagate secretness correctly in Python `apply` * Improve `apply` test coverage * Update CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: I didn't add any new tests for Go -- I'll need to look into that a bit more and see if it could use any additional coverage.
Fixes #4163