fix: remove --show-* as persistent flags #4294
Conversation
pkg/cmd/stack.go
Outdated
| &showIDs, "show-ids", "i", false, "Display each resource's provider-assigned unique ID") | ||
| cmd.PersistentFlags().BoolVarP( | ||
| cmd.Flags().BoolVarP( | ||
| &showURNs, "show-urns", "u", false, "Display each resource's Pulumi-assigned globally unique URN") | ||
| cmd.PersistentFlags().BoolVar( |
There was a problem hiding this comment.
What about show-secrets?
| cmd.PersistentFlags().BoolVar( | |
| cmd.Flags().BoolVar( |
There was a problem hiding this comment.
I didn't change that as I wasn't sure if it affected stack output or not.
There was a problem hiding this comment.
I actually went back and looked at the reason for this. --show-ids and --show-urns are flags for pulumi stack itself, which --show-secrets I believe to affect export and such.
There was a problem hiding this comment.
I looked into this in more detail.
There is a pulumi stack output command which also accepts --show-secrets, but it redefines this flag for itself.
There's no other commands under stack that refers to its showSecrets bool variable or is otherwise looking for "show-secrets", so we should be able to change it here from PersistentFlags to Flags.
|
@nesl247 I am going to merge this manually since the tests don't run on a community PR (which we will be fixing soon!!!) Thanks for the work here - it's very much appreciated |
Fixes #4290