Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: error when setting config without value in non-interactive mode #4358

Closed
wants to merge 1 commit into from
Closed

fix: error when setting config without value in non-interactive mode #4358

wants to merge 1 commit into from

Conversation

nesl247
Copy link
Contributor

@nesl247 nesl247 commented Apr 10, 2020

Fixes #4336

@justinvp justinvp self-requested a review April 10, 2020 16:16
justinvp
justinvp requested changes Apr 10, 2020
View reviewed changes
Copy link
Member

@justinvp justinvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nesl247! The check needs to be moved, but LGTM otherwise.

pkg/cmd/pulumi/config.go Outdated Show resolved Hide resolved
justinvp
justinvp approved these changes Apr 10, 2020
View reviewed changes
Copy link
Member

@justinvp justinvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stack72
Copy link
Contributor

stack72 commented Apr 10, 2020

I manually merged this @nesl247

Thanks again!! :)

@stack72 stack72 closed this Apr 10, 2020
@stack72 stack72 mentioned this pull request Apr 10, 2020
Closed
@nesl247 nesl247 deleted the pulumi-4336 branch April 10, 2020 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinvp justinvp justinvp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

pulumi config set command in non interacting mode ask for values
3 participants
@nesl247 @stack72 @justinvp