Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable fish completions for pulumi cli #4401

Merged
merged 2 commits into from
Apr 30, 2020
Merged

Enable fish completions for pulumi cli #4401

merged 2 commits into from
Apr 30, 2020

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Apr 15, 2020

Fixes: #4375

This upgrades cobra to 1.0.0 (we were on 0.0.6 and only 0.0.7 was
available before 1.0.0). This enables us to allow users to generate
fish completions. We have defaulted to including the fish completion
description by default

Fixes: #4375

This upgrades cobra to 1.0.0 (we were on 0.0.6 and only 0.0.7 was
available before 1.0.0). This enables us to allow users to generate
fish completions. We have defaulted to including the fish completion
description by default
Copy link
Member

@justinvp justinvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Is this for 2.0 or post-2.0?

@stack72
Copy link
Contributor Author

stack72 commented Apr 16, 2020

Post-2.0 @justinvp

@stack72 stack72 merged commit f06e48b into master Apr 30, 2020
@stack72 stack72 deleted the fish-completions branch April 30, 2020 14:46
@nesl247
Copy link
Contributor

nesl247 commented May 28, 2020

This was merged, but they don't seem to be installed automatically when installing from homebrew. This really should be handled automatically like other applications.

I've opened #4721 for this

@gerrywastaken
Copy link

@stack72 While you added this I doubt many people know it exists: https://www.pulumi.com/docs/reference/cli/#command-line-completion

I only ended up guessing and getting lucky.

@stack72
Copy link
Contributor Author

stack72 commented Mar 19, 2021

Thanks @gerrywastaken I will get that added to the guide!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fish shell completions
4 participants