Fix NRE in C# mocks and include the stack to result again #4656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinvp
approved these changes
May 18, 2020
CHANGELOG.md
Outdated
| @@ -6,6 +6,9 @@ CHANGELOG | |||
| - Add support for untagged outputs in Go SDK. | |||
| [#4640](https://github.com/pulumi/pulumi/pull/4640) | |||
|
|
|||
| - Fix a tegression in .NET unit testing. | |||
There was a problem hiding this comment.
Suggested change
| - Fix a tegression in .NET unit testing. | |
| - Fix a Regression in .NET unit testing. |
|
@justinvp Thanks for the review. I added a test that reveals both problems. Do you mind taking another quick look? |
abhinav
pushed a commit
to pulumi/pulumi-dotnet
that referenced
this pull request
Jan 11, 2023
…umi#4656) Fix NRE in C# mocks and include the stack to result again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4655
Fixes both points:
pulumi/sdk/dotnet/Pulumi/Deployment/Deployment_ReadOrRegisterResource.cs
Line 95 in 30b12cf