-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Turn program gen NYIs into diagnostic errors #4794
Conversation
Diff for pulumi-random with merge commit 1bd11c5 |
Diff for pulumi-azuread with merge commit 1bd11c5 |
Diff for pulumi-kubernetes with merge commit 1bd11c5 |
Diff for pulumi-gcp with merge commit 1bd11c5 |
Diff for pulumi-aws with merge commit 1bd11c5 |
Diff for pulumi-azuread with merge commit b49fc3e |
Diff for pulumi-random with merge commit b49fc3e |
Diff for pulumi-azure with merge commit 1bd11c5 |
Diff for pulumi-kubernetes with merge commit b49fc3e |
Diff for pulumi-gcp with merge commit b49fc3e |
Diff for pulumi-aws with merge commit b49fc3e |
Diff for pulumi-azure with merge commit b49fc3e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just one nit re: wording.
pkg/codegen/dotnet/gen_program.go
Outdated
@@ -468,5 +468,11 @@ func (g *generator) genOutputProperty(w io.Writer, v *hcl2.OutputVariable) { | |||
} | |||
|
|||
func (g *generator) genNYI(w io.Writer, reason string, vs ...interface{}) { | |||
message := fmt.Sprintf("unimplemented expression: %s", fmt.Sprintf(reason, vs...)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: this can be used more generally than in expressions.
message := fmt.Sprintf("unimplemented expression: %s", fmt.Sprintf(reason, vs...)) | |
message := fmt.Sprintf("not yet implemented: %s", fmt.Sprintf(reason, vs...)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(same feedback throughout)
Diff for pulumi-random with merge commit e2c6764 |
Diff for pulumi-azuread with merge commit e2c6764 |
Diff for pulumi-kubernetes with merge commit e2c6764 |
Diff for pulumi-gcp with merge commit e2c6764 |
Diff for pulumi-aws with merge commit e2c6764 |
Diff for pulumi-azure with merge commit e2c6764 |
Fixes #4782
Fixed this consistently for all languages. This removes a hand full of C# examples from the AWS provider.
Diff here with everything linked locally: https://github.com/pulumi/pulumi-aws/compare/evan/goExamples