Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn program gen NYIs into diagnostic errors #4794

Merged
merged 3 commits into from
Jun 10, 2020
Merged

Conversation

EvanBoyle
Copy link
Contributor

Fixes #4782

Fixed this consistently for all languages. This removes a hand full of C# examples from the AWS provider.

Diff here with everything linked locally: https://github.com/pulumi/pulumi-aws/compare/evan/goExamples

@EvanBoyle EvanBoyle requested a review from pgavlin June 10, 2020 16:02
@github-actions
Copy link

Diff for pulumi-random with merge commit 1bd11c5

@github-actions
Copy link

Diff for pulumi-azuread with merge commit 1bd11c5

@github-actions
Copy link

Diff for pulumi-kubernetes with merge commit 1bd11c5

@github-actions
Copy link

Diff for pulumi-gcp with merge commit 1bd11c5

@github-actions
Copy link

Diff for pulumi-aws with merge commit 1bd11c5

@github-actions
Copy link

Diff for pulumi-azuread with merge commit b49fc3e

@github-actions
Copy link

Diff for pulumi-random with merge commit b49fc3e

@github-actions
Copy link

Diff for pulumi-azure with merge commit 1bd11c5

@github-actions
Copy link

Diff for pulumi-kubernetes with merge commit b49fc3e

@github-actions
Copy link

Diff for pulumi-gcp with merge commit b49fc3e

@github-actions
Copy link

Diff for pulumi-aws with merge commit b49fc3e

@github-actions
Copy link

Diff for pulumi-azure with merge commit b49fc3e

@EvanBoyle EvanBoyle added the area/codegen SDK-gen, program-gen, convert label Jun 10, 2020
Copy link
Member

@pgavlin pgavlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just one nit re: wording.

@@ -468,5 +468,11 @@ func (g *generator) genOutputProperty(w io.Writer, v *hcl2.OutputVariable) {
}

func (g *generator) genNYI(w io.Writer, reason string, vs ...interface{}) {
message := fmt.Sprintf("unimplemented expression: %s", fmt.Sprintf(reason, vs...))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: this can be used more generally than in expressions.

Suggested change
message := fmt.Sprintf("unimplemented expression: %s", fmt.Sprintf(reason, vs...))
message := fmt.Sprintf("not yet implemented: %s", fmt.Sprintf(reason, vs...))

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(same feedback throughout)

@github-actions
Copy link

Diff for pulumi-random with merge commit e2c6764

@github-actions
Copy link

Diff for pulumi-azuread with merge commit e2c6764

@github-actions
Copy link

Diff for pulumi-kubernetes with merge commit e2c6764

@github-actions
Copy link

Diff for pulumi-gcp with merge commit e2c6764

@github-actions
Copy link

Diff for pulumi-aws with merge commit e2c6764

@github-actions
Copy link

Diff for pulumi-azure with merge commit e2c6764

@EvanBoyle EvanBoyle merged commit 45a901d into master Jun 10, 2020
@pulumi-bot pulumi-bot deleted the evan/programGenNYIDiags branch June 10, 2020 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/codegen SDK-gen, program-gen, convert
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Go Program Gen] Turn NYIs into diagnostic errors
2 participants