Fix pylint(no-member) when accessing resource.id #4813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pylint currently reports `E1101: Instance of 'Bucket' has no 'id' member (no-member)` on lines in Pulumi Python programs like:
```python
pulumi.export('bucket_name', bucket.id)
```
Here's a description of this message from http://pylint-messages.wikidot.com/messages:e1101:
> Used when an object (variable, function, …) is accessed for a non-existent member.
>
> False positives: This message may report object members that are created dynamically, but exist at the time they are accessed.
This is a false positive because `id` isn't set in the initializer method, it's set later in `register_resource` and Pylint isn't able to figure this out statically.
This change refactors `register_resource` so that `id` (and `urn`) can be assigned in the resource's initializer, so that Pylint can see it being assigned, and does the same for `read_resource`.
pgavlin
approved these changes
Jun 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pylint currently reports
E1101: Instance of 'Bucket' has no 'id' member (no-member)on lines in Pulumi Python programs like:Here's a description of this message from http://pylint-messages.wikidot.com/messages:e1101:
This appears to be a false positive case:
idisn't set in the constructor (it's set later inregister_resource) and Pylint isn't able to figure this out statically.urnhas the same problem. (Oddly, Pylint doesn't complain when accessing other resource output properties).This change refactors
register_resourceso thatidandurncan be assigned in the resource's constructor, so that Pylint can see it being assigned. The change also does the same withread_resource.Fixes #3765