Go program gen: resource range, readDir, template strings, etc #4818
Conversation
|
Diff for pulumi-azuread with merge commit 3e145eb |
|
Diff for pulumi-random with merge commit 3e145eb |
|
Diff for pulumi-kubernetes with merge commit 3e145eb |
|
Diff for pulumi-gcp with merge commit 3e145eb |
|
Diff for pulumi-kubernetes with merge commit db3de5b |
|
Diff for pulumi-random with merge commit db3de5b |
|
Diff for pulumi-azuread with merge commit db3de5b |
|
Diff for pulumi-gcp with merge commit db3de5b |
|
Diff for pulumi-aws with merge commit 3e145eb |
|
Diff for pulumi-azure with merge commit 3e145eb |
|
Diff for pulumi-azure with merge commit db3de5b |
|
Diff for pulumi-aws with merge commit db3de5b |
|
Diff for pulumi-azuread with merge commit e895e86 |
|
Diff for pulumi-random with merge commit e895e86 |
|
Diff for pulumi-kubernetes with merge commit e895e86 |
|
Diff for pulumi-gcp with merge commit e895e86 |
|
Diff for pulumi-aws with merge commit e895e86 |
|
Diff for pulumi-azure with merge commit e895e86 |
|
Diff for pulumi-azuread with merge commit 1d317f9 |
|
Diff for pulumi-kubernetes with merge commit 1d317f9 |
|
Diff for pulumi-random with merge commit 1d317f9 |
|
Diff for pulumi-gcp with merge commit 1d317f9 |
|
Diff for pulumi-azure with merge commit 1d317f9 |
|
Diff for pulumi-aws with merge commit 1d317f9 |
| @@ -608,10 +629,11 @@ func (nameInfo) Format(name string) string { | |||
| // lowerExpression amends the expression with intrinsics for C# generation. | |||
There was a problem hiding this comment.
| // lowerExpression amends the expression with intrinsics for C# generation. | |
| // lowerExpression amends the expression with intrinsics for Go generation. |
There was a problem hiding this comment.
Will fix this in my next PR
| _, err = s3.NewBucketObject(ctx, "files-"+string(i0), &s3.BucketObjectArgs{ | ||
| Bucket: siteBucket.ID(), | ||
| Key: pulumi.String(val0), | ||
| Source: pulumi.NewFileAsset(fmt.Sprintf("%v%v%v", siteDir, "/", val0)), |
There was a problem hiding this comment.
I realize that this is a result of the input program, but paths should really use path.Join instead of a hardcoded slash.
There was a problem hiding this comment.
Agreed, but there isn't really a good way to handle this (at least in terms of a sensible effort/reward ratio). The other language generators do the same.
|
Merging this to get the next PR open. Happy to address any late feedback in a new changeset. |
| @@ -202,9 +267,32 @@ func (g *generator) genTemps(w io.Writer, temps []interface{}) { | |||
| args := stripInputs(t.Value.Args[0]) | |||
| g.Fgenf(w, "%.v)\n", args) | |||
| g.Fgenf(w, "if err != nil {\n") | |||
| g.Fgenf(w, "return err\n") | |||
| if genZeroValueDecl { | |||
| g.Fgenf(w, "return _zero, err\n") | |||
There was a problem hiding this comment.
Another way to do this is *new(T), which is maybe a bit more obscure, but has the benefit of avoiding the variable declaration.
There was a problem hiding this comment.
Ah, a good tip for the tool belt. I think it might be favorable to avoid obscure syntax for code snippets and docs. Will leave as is unless you have other objections.
| type readDirTemp struct { | ||
| Name string | ||
| Value *model.FunctionCallExpression | ||
| } |
There was a problem hiding this comment.
We should think about unifying these temp kinds in the future.
There was a problem hiding this comment.
With what goal? Eliminating redundancy in the spillers?
Everything needed to support the s3-folder example. Also added a step to build a set of scope traversal tools allowing later replacement of unused variable declarations with
_.Fixes #4781
Fixes #4771