Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Go Program Gen] multiline strings, get/lookup disambiguation, webserver example #4850

Merged
merged 6 commits into from
Jun 18, 2020
Merged

[Go Program Gen] multiline strings, get/lookup disambiguation, webserver example #4850

merged 6 commits into from
Jun 18, 2020

Conversation

EvanBoyle
Copy link
Contributor

@EvanBoyle EvanBoyle commented Jun 18, 2020 •
edited
Loading

Fixes #4836
Fixes #4770

In addition to the title items, I also added support for "namespaceless" invokes for things under the "index" or "" module. This also illuminated an import bug, where we weren't scanning invoke functions for packages so I added support for this.

Pushed another commit to fix #4762 (inputty map types for pulumi.Map (Tags))

@github-actions
Copy link

Diff for pulumi-azuread with merge commit 053aeef

@github-actions
Copy link

Diff for pulumi-random with merge commit 053aeef

@github-actions
Copy link

Diff for pulumi-kubernetes with merge commit 053aeef

@github-actions
Copy link

Diff for pulumi-azuread with merge commit 00017ae

@github-actions
Copy link

Diff for pulumi-kubernetes with merge commit 00017ae

@github-actions
Copy link

Diff for pulumi-random with merge commit 00017ae

@github-actions
Copy link

Diff for pulumi-gcp with merge commit 053aeef

@github-actions
Copy link

Diff for pulumi-gcp with merge commit 00017ae

@github-actions
Copy link

Diff for pulumi-azure with merge commit 053aeef

@github-actions
Copy link

Diff for pulumi-azure with merge commit 00017ae

@github-actions
Copy link

Diff for pulumi-aws with merge commit 053aeef

@github-actions
Copy link

Diff for pulumi-aws with merge commit 00017ae

@github-actions
Copy link

Diff for pulumi-azuread with merge commit ceac04b

@github-actions
Copy link

Diff for pulumi-random with merge commit ceac04b

@github-actions
Copy link

Diff for pulumi-kubernetes with merge commit ceac04b

@github-actions
Copy link

Diff for pulumi-gcp with merge commit ceac04b

@github-actions
Copy link

Diff for pulumi-azure with merge commit ceac04b

@github-actions
Copy link

Diff for pulumi-aws with merge commit ceac04b

@github-actions
Copy link

Diff for pulumi-azuread with merge commit 06ac362

@github-actions
Copy link

Diff for pulumi-random with merge commit 06ac362

@github-actions
Copy link

Diff for pulumi-kubernetes with merge commit 06ac362

@github-actions
Copy link

Diff for pulumi-gcp with merge commit 06ac362

@github-actions
Copy link

Diff for pulumi-aws with merge commit 06ac362

@github-actions
Copy link

Diff for pulumi-azure with merge commit 06ac362

@github-actions
Copy link

Diff for pulumi-azuread with merge commit 6f3ee7f

@github-actions
Copy link

Diff for pulumi-random with merge commit 6f3ee7f

@github-actions
Copy link

Diff for pulumi-kubernetes with merge commit 6f3ee7f

@github-actions
Copy link

Diff for pulumi-gcp with merge commit 6f3ee7f

@github-actions
Copy link

Diff for pulumi-aws with merge commit 6f3ee7f

@github-actions
Copy link

Diff for pulumi-azure with merge commit 6f3ee7f

lblackstone
lblackstone requested changes Jun 18, 2020
View reviewed changes
Copy link
Member

@lblackstone lblackstone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall.

pkg/codegen/go/gen_program.go Outdated Show resolved Hide resolved
pkg/codegen/go/gen_program.go Show resolved Hide resolved
pgavlin
pgavlin approved these changes Jun 18, 2020
View reviewed changes
Copy link
Member

@pgavlin pgavlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from Levi's feedback.

pkg/codegen/go/gen_program_expressions.go Show resolved Hide resolved
@github-actions
Copy link

Diff for pulumi-azuread with merge commit 4be9db2

@EvanBoyle EvanBoyle mentioned this pull request Jun 18, 2020
Open
@github-actions
Copy link

Diff for pulumi-kubernetes with merge commit 4be9db2

@github-actions
Copy link

Diff for pulumi-random with merge commit 4be9db2

@github-actions
Copy link

Diff for pulumi-gcp with merge commit 4be9db2

@github-actions
Copy link

Diff for pulumi-azure with merge commit 4be9db2

@github-actions
Copy link

Diff for pulumi-aws with merge commit 4be9db2

@EvanBoyle EvanBoyle merged commit 8b81702 into master Jun 18, 2020
@pulumi-bot pulumi-bot deleted the evan/goGenWebserver branch June 18, 2020 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lblackstone lblackstone lblackstone requested changes

@pgavlin pgavlin pgavlin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@EvanBoyle @pgavlin @lblackstone