go program gen: lift expressions where prompt optionals are required #4875
Conversation
|
Diff for pulumi-azuread with merge commit 689b1e5 |
|
Diff for pulumi-random with merge commit 689b1e5 |
|
Diff for pulumi-kubernetes with merge commit 689b1e5 |
|
Diff for pulumi-random with merge commit 10c8074 |
|
Diff for pulumi-azuread with merge commit 10c8074 |
|
Diff for pulumi-kubernetes with merge commit 10c8074 |
|
Diff for pulumi-gcp with merge commit 689b1e5 |
|
Diff for pulumi-gcp with merge commit 10c8074 |
|
Diff for pulumi-azure with merge commit 689b1e5 |
|
Diff for pulumi-aws with merge commit 689b1e5 |
|
Diff for pulumi-aws with merge commit 10c8074 |
|
Diff for pulumi-azure with merge commit 10c8074 |
| @@ -25,6 +25,7 @@ func main() { | |||
| if err != nil { | |||
| return err | |||
| } | |||
| opt0 := true | |||
There was a problem hiding this comment.
Out of scope for this PR, but it might be nice to have helper methods to generate references for optional types without requiring a temporary variable. I believe Kubernetes client-go has something like this.
There was a problem hiding this comment.
Yeah, I'm in this camp as well. My understanding was that it is more idiomatic in go to spell stuff like this out even if repetitive. This was the general feedback I got when suggesting we add helpers to the go SDK to translate prompt arrays to inputty arrays. @pgavlin can comment more here.
There was a problem hiding this comment.
It is less idiomatic to export simple, type-specific helper methods. I'm ambivalent about adding unexported helper methods to the generated code.
|
Diff for pulumi-random with merge commit 2cb2c9e |
|
Diff for pulumi-azuread with merge commit 2cb2c9e |
|
Diff for pulumi-kubernetes with merge commit 2cb2c9e |
|
Diff for pulumi-gcp with merge commit 2cb2c9e |
|
Diff for pulumi-azure with merge commit 2cb2c9e |
|
Diff for pulumi-aws with merge commit 2cb2c9e |
Fixes #4768
Prompt optional values for primitives must be passed as pointers. This change adds a lowering step that hoists the concrete value into the outer scope where appropriate (currently only invoke args) and replaces the original reference with a scope traversal (
&optN).This changeset is based on another open PR in an effort to keep the changes small and easy to review: #4858