[Go Program Gen] Improved handling for pulumi.Map types #4914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Diff for pulumi-random with merge commit 595ec8a |
|
Diff for pulumi-azuread with merge commit 595ec8a |
|
Diff for pulumi-kubernetes with merge commit 595ec8a |
|
Diff for pulumi-random with merge commit e4bd13a |
|
Diff for pulumi-gcp with merge commit 595ec8a |
|
Diff for pulumi-kubernetes with merge commit e4bd13a |
|
Diff for pulumi-azuread with merge commit e4bd13a |
|
Diff for pulumi-azure with merge commit 595ec8a |
|
Diff for pulumi-gcp with merge commit e4bd13a |
|
Diff for pulumi-aws with merge commit 595ec8a |
|
Diff for pulumi-azure with merge commit e4bd13a |
|
Tags look good in the generated diff across providers. Here's another AWS specific bug that was called out in the issue now generating the proper |
|
Diff for pulumi-aws with merge commit e4bd13a |
lblackstone
approved these changes
Jun 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4903
Also went ahead and refreshed the local aws schema. When doing this, I noticed that the
versionfield is no longer populated, and as a result my code was panicking on dereference ofp.Version.Major. I manually added the version field into the AWS schema, but wanted to double check that this field is populated at runtime @pgavlin