Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[codegen/python] Fix pyname bug #4918

Merged
merged 7 commits into from
Aug 5, 2020
Merged

[codegen/python] Fix pyname bug #4918

merged 7 commits into from
Aug 5, 2020

Conversation

komalali
Copy link
Member

@komalali komalali commented Jun 27, 2020 •
edited
Loading

@komalali komalali added the impact/breaking Fixing this issue will require a breaking change label Jun 27, 2020
@github-actions
Copy link

Diff for pulumi-azuread with merge commit f9067ee

@github-actions
Copy link

Diff for pulumi-kubernetes with merge commit f9067ee

@github-actions
Copy link

Diff for pulumi-random with merge commit f9067ee

@github-actions
Copy link

Diff for pulumi-gcp with merge commit f9067ee

@github-actions
Copy link

Diff for pulumi-aws with merge commit f9067ee

@github-actions
Copy link

Diff for pulumi-azure with merge commit f9067ee

@komalali komalali mentioned this pull request Jun 29, 2020
Closed
@github-actions
Copy link

github-actions bot commented Aug 4, 2020

Diff for pulumi-random with merge commit 6e7ef50

@github-actions
Copy link

github-actions bot commented Aug 4, 2020

Diff for pulumi-azuread with merge commit 6e7ef50

@komalali komalali removed the impact/breaking Fixing this issue will require a breaking change label Aug 4, 2020
@github-actions
Copy link

github-actions bot commented Aug 4, 2020

Diff for pulumi-kubernetes with merge commit 6e7ef50

@github-actions
Copy link

github-actions bot commented Aug 4, 2020

Diff for pulumi-gcp with merge commit 6e7ef50

@github-actions
Copy link

github-actions bot commented Aug 4, 2020

Diff for pulumi-aws with merge commit 6e7ef50

@komalali komalali added the impact/no-changelog-required This issue doesn't require a CHANGELOG update label Aug 4, 2020
@komalali komalali marked this pull request as ready for review August 4, 2020 22:21
@github-actions
Copy link

github-actions bot commented Aug 4, 2020

Diff for pulumi-azuread with merge commit 588405e

@github-actions
Copy link

github-actions bot commented Aug 4, 2020

Diff for pulumi-random with merge commit 588405e

@github-actions
Copy link

github-actions bot commented Aug 4, 2020

Diff for pulumi-kubernetes with merge commit 588405e

justinvp
justinvp reviewed Aug 4, 2020
View reviewed changes
pkg/codegen/python/python.go Outdated Show resolved Hide resolved
pkg/codegen/python/python_test.go
{"SHA256Hash", "sha256_hash"},
}

func TestPyName(t *testing.T) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add some tests for the legacy behavior to ensure it doesn't change?

@github-actions
Copy link

github-actions bot commented Aug 4, 2020

Diff for pulumi-gcp with merge commit 588405e

@github-actions
Copy link

github-actions bot commented Aug 4, 2020

Diff for pulumi-aws with merge commit 588405e

@github-actions
Copy link

github-actions bot commented Aug 4, 2020

Diff for pulumi-random with merge commit a81bab6

@github-actions
Copy link

github-actions bot commented Aug 4, 2020

Diff for pulumi-azuread with merge commit a81bab6

@github-actions
Copy link

github-actions bot commented Aug 4, 2020

Diff for pulumi-kubernetes with merge commit a81bab6

@github-actions
Copy link

github-actions bot commented Aug 4, 2020

Diff for pulumi-gcp with merge commit a81bab6

@github-actions
Copy link

github-actions bot commented Aug 4, 2020

Diff for pulumi-gcp with merge commit 2c968f3

@github-actions
Copy link

github-actions bot commented Aug 4, 2020

Diff for pulumi-aws with merge commit a81bab6

@github-actions
Copy link

github-actions bot commented Aug 4, 2020

Diff for pulumi-aws with merge commit 2c968f3

justinvp
justinvp approved these changes Aug 4, 2020
View reviewed changes
Copy link
Member

@justinvp justinvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise, thanks!

pkg/codegen/python/python_test.go Show resolved Hide resolved
pkg/codegen/python/python_test.go Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Aug 4, 2020

Diff for pulumi-azuread with merge commit 66cda43

@github-actions
Copy link

github-actions bot commented Aug 4, 2020

Diff for pulumi-random with merge commit 66cda43

@github-actions
Copy link

github-actions bot commented Aug 4, 2020

Diff for pulumi-kubernetes with merge commit 66cda43

@github-actions
Copy link

github-actions bot commented Aug 4, 2020

Diff for pulumi-gcp with merge commit 66cda43

@github-actions
Copy link

github-actions bot commented Aug 4, 2020

Diff for pulumi-aws with merge commit 66cda43

@github-actions
Copy link

github-actions bot commented Aug 5, 2020

Diff for pulumi-random with merge commit 963cdb1

@github-actions
Copy link

github-actions bot commented Aug 5, 2020

Diff for pulumi-azuread with merge commit 963cdb1

@github-actions
Copy link

github-actions bot commented Aug 5, 2020

Diff for pulumi-kubernetes with merge commit 963cdb1

@github-actions
Copy link

github-actions bot commented Aug 5, 2020

Diff for pulumi-gcp with merge commit 963cdb1

@github-actions
Copy link

github-actions bot commented Aug 5, 2020

Diff for pulumi-aws with merge commit 963cdb1

@github-actions
Copy link

github-actions bot commented Aug 5, 2020

Diff for pulumi-azure with merge commit 963cdb1

@komalali komalali merged commit d2dd990 into master Aug 5, 2020
@komalali komalali deleted the komalali/pyname-bug branch August 5, 2020 17:08
komalali added a commit that referenced this pull request Aug 5, 2020
@komalali
[codegen/python] Fix pyname bug (#4918)
8dc6d84
This was referenced Aug 14, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@justinvp justinvp justinvp approved these changes

@lblackstone lblackstone lblackstone approved these changes

@pgavlin pgavlin Awaiting requested review from pgavlin

Assignees
No one assigned
Labels
impact/no-changelog-required This issue doesn't require a CHANGELOG update
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect snake_case translation for certain properties.
3 participants
@komalali @justinvp @lblackstone