Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add plugin download url metadata to package spec #4947

Merged
merged 4 commits into from
Jul 21, 2020
Merged

add plugin download url metadata to package spec #4947

merged 4 commits into from
Jul 21, 2020

Conversation

jaxxstorm
Copy link
Contributor

@jaxxstorm jaxxstorm commented Jul 2, 2020 •
edited
Loading

This optional field allows providers and plugins to specify a URL to download a provider plugin from. This will allow community plugins to use automatic plugin acquisition

Currently this is just a noop, the same changes need to be passed through to pulumi-terraform-bridge as well.

@github-actions
Copy link

github-actions bot commented Jul 2, 2020

Diff for pulumi-azuread with merge commit a857464

@github-actions
Copy link

github-actions bot commented Jul 2, 2020

Diff for pulumi-random with merge commit a857464

@github-actions
Copy link

github-actions bot commented Jul 2, 2020

Diff for pulumi-kubernetes with merge commit a857464

@github-actions
Copy link

github-actions bot commented Jul 2, 2020

Diff for pulumi-azuread with merge commit f18e16f

@github-actions
Copy link

github-actions bot commented Jul 2, 2020

Diff for pulumi-random with merge commit f18e16f

@github-actions
Copy link

github-actions bot commented Jul 2, 2020

Diff for pulumi-kubernetes with merge commit f18e16f

@github-actions
Copy link

github-actions bot commented Jul 2, 2020

Diff for pulumi-azure with merge commit a857464

@github-actions
Copy link

github-actions bot commented Jul 2, 2020

Diff for pulumi-aws with merge commit a857464

@github-actions
Copy link

github-actions bot commented Jul 2, 2020

Diff for pulumi-gcp with merge commit a857464

@github-actions
Copy link

github-actions bot commented Jul 2, 2020

Diff for pulumi-aws with merge commit f18e16f

@jaxxstorm jaxxstorm mentioned this pull request Jul 2, 2020
Merged
@github-actions
Copy link

github-actions bot commented Jul 2, 2020

Diff for pulumi-azure with merge commit f18e16f

@github-actions
Copy link

github-actions bot commented Jul 2, 2020

Diff for pulumi-gcp with merge commit f18e16f

@jaxxstorm jaxxstorm changed the title add provider url metadata to package spec add plugin download url metadata to package spec Jul 2, 2020
@jaxxstorm
switch terminology to plugin download URL
c25cbf0 
After a discussion about terminology, the better phrasing is to use
pluginDownloadURL
@github-actions
Copy link

github-actions bot commented Jul 2, 2020

Diff for pulumi-random with merge commit bd6da18

@github-actions
Copy link

github-actions bot commented Jul 2, 2020

Diff for pulumi-azuread with merge commit bd6da18

@github-actions
Copy link

github-actions bot commented Jul 2, 2020

Diff for pulumi-kubernetes with merge commit bd6da18

@github-actions
Copy link

github-actions bot commented Jul 2, 2020

Diff for pulumi-gcp with merge commit bd6da18

@github-actions
Copy link

github-actions bot commented Jul 2, 2020

Diff for pulumi-azure with merge commit bd6da18

@github-actions
Copy link

github-actions bot commented Jul 2, 2020

Diff for pulumi-aws with merge commit bd6da18

@github-actions
Copy link

Diff for pulumi-azuread with merge commit 2ba5f5d

@github-actions
Copy link

Diff for pulumi-random with merge commit 2ba5f5d

@github-actions
Copy link

Diff for pulumi-kubernetes with merge commit 2ba5f5d

@github-actions
Copy link

Diff for pulumi-gcp with merge commit 2ba5f5d

@github-actions
Copy link

Diff for pulumi-aws with merge commit 2ba5f5d

@github-actions
Copy link

Diff for pulumi-azure with merge commit 2ba5f5d

stack72
stack72 reviewed Jul 21, 2020
View reviewed changes
Copy link
Contributor

@stack72 stack72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will this approach only work for python and NodeJS? What can be done about Go/DotNet - or is that a different conversation?

The code looks fine here - have you been able to hook this up to a provider to get it working?

@jaxxstorm
Copy link
Contributor Author

@stack72 yes it'll only work for those languages. I have a successful test working with the rke provider which i'll send over!

@jaxxstorm jaxxstorm merged commit c9fedef into master Jul 21, 2020
@pulumi-bot pulumi-bot deleted the jaxxstorm/provider-info branch July 21, 2020 19:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stack72 stack72 stack72 left review comments

@lukehoban lukehoban Awaiting requested review from lukehoban

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jaxxstorm @stack72