Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docker/actions] unset GOOGLE_CREDENTIALS #4972

Merged
merged 1 commit into from
Jul 7, 2020
Merged

[docker/actions] unset GOOGLE_CREDENTIALS #4972

merged 1 commit into from
Jul 7, 2020

Conversation

simenandre
Copy link
Contributor

Hello 👋

This PR will fix issue where base64 encoded GOOGLE_CREDENTIALS causes commands/invocations to fail.

Example issue:

Error: invocation of gcp:container/getRegistryImage:getRegistryImage returned an error:
could not validate provider configuration:

1 error occurred:
* JSON credentials in "***" are not valid: invalid character 'e' looking for beginning of value

I've pushed these changes to this: https://hub.docker.com/r/cobraz/pulumi-actions-bugfixing
Tested on my own Github Actions setup.

Thanks for Pulumi ❤️

stack72
stack72 approved these changes Jul 7, 2020
View reviewed changes
Copy link
Contributor

@stack72 stack72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah nice fix here! Apologies that was causing you problems

@stack72 stack72 merged commit b0d9280 into pulumi:master Jul 7, 2020
@simenandre
Copy link
Contributor Author

I probably caused it! 😅

@simenandre simenandre deleted the unset-google-auth branch July 10, 2020 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stack72 stack72 stack72 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@simenandre @stack72