switch os/user with luser #5065
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaxxstorm
force-pushed
the
jaxxstorm/luser
branch
3 times, most recently
from
ef76a5b
to
80acac0
Compare
EvanBoyle
approved these changes
Jul 27, 2020
We make several calls to `os/user`, which uses CGO and means cross-compilation is not possible. This replaces `os/user` with the `luser` package, which is a drop-in replacement which does not use `CGO`
jaxxstorm
force-pushed
the
jaxxstorm/luser
branch
from
80acac0
to
bad67d3
Compare
Yeah we do, but the intent is to encapsulate the build process into a single build step with goreleaser to remove a bunch of the manual/custom shell scripts, which needs cross-compilation to be enabled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We make several calls to
os/user, which uses CGO and meanscross-compilation is not possible. This replaces
os/userwith theluserpackage, which is a drop-in replacement which does not useCGO