Enable pushing to Artifact Registry in actions #5075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To authenticate with GCP Artifact Registry, the `gcloud auth configure-docker` command requires a comma separated list of hostnames to add helpers for. https://cloud.google.com/artifact-registry/docs/docker/authentication#gcloud-helper
|
This would be super useful for me! hopefully it gets approved soon, looks good to my beginner eyes! 😄 |
leezen
approved these changes
Aug 18, 2020
leezen
approved these changes
Aug 18, 2020
There was a problem hiding this comment.
@OliverHGray Looks good, but I think it might make more sense to prepend the name of the env var with GOOGLE_ to be consistent with the other env vars as it's GCP-specific?
Prefix variable name with GOOGLE
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To authenticate with GCP Artifact Registry, the
gcloud auth configure-dockercommand requires a comma separated list of hostnames to add helpers for. https://cloud.google.com/artifact-registry/docs/docker/authentication#gcloud-helper