Ensure Project Stack is not loaded and saved unnecessariliy for default secrets manager #5132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lt secrets manager Fixes: #5126 In the newServiceSecretsManager, we were loading and saving the project stack without understanding if any changes had actually been made - e.g. changing the stack to be a new secrets provider This has now been guarded against, tests added to understand when it will actually be saved and we no longer get unnecessary config sorting when interacting with a default stack AND no longer get an empty config map in our config file when we initiate a new stack with a default secrets provider
stack72
requested review from
lukehoban and
justinvp
and removed request for
lukehoban
EvanBoyle
approved these changes
Aug 7, 2020
|
Merged in d03d2b1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5126
In the newServiceSecretsManager, we were loading and saving the project stack
without understanding if any changes had actually been made - e.g. changing the
stack to be a new secrets provider
This has now been guarded against, tests added to understand when it will
actually be saved and we no longer get unnecessary config sorting when interacting
with a default stack AND no longer get an empty config map in our config
file when we initiate a new stack with a default secrets provider