Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(autoapi): add workspace scoped envvars to LocalWorkspace and Stack #5275

Merged
merged 1 commit into from
Sep 3, 2020
Merged

feat(autoapi): add workspace scoped envvars to LocalWorkspace and Stack #5275

merged 1 commit into from
Sep 3, 2020

Conversation

metral
Copy link
Contributor

@metral metral commented Sep 2, 2020

Closes #5227

@metral metral force-pushed the metral/autoapi-envvars branch 2 times, most recently from 14fced2 to c5f216c Compare September 2, 2020 18:10
EvanBoyle
EvanBoyle reviewed Sep 2, 2020
View reviewed changes
Copy link
Contributor

@EvanBoyle EvanBoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two suggestions to consider but overall looks great!

sdk/go/x/auto/local_workspace.go Show resolved Hide resolved
sdk/go/x/auto/local_workspace.go Outdated Show resolved Hide resolved
@EvanBoyle
Copy link
Contributor

Would also be great to see some examples for the documentation side of things:

pulumi/sdk/go/x/auto/example_test.go

Line 797 in c23f26b

func ExampleStack_SetAllConfig() {

EvanBoyle
EvanBoyle approved these changes Sep 3, 2020
View reviewed changes
Copy link
Contributor

@EvanBoyle EvanBoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation and examples look great!

If I had to guess, tests are failing due to the uninitialized map. Probably just need to initialize it here in NewLocalWorkspace:

pulumi/sdk/go/x/auto/local_workspace.go

Line 455 in dec6a6a

pulumiHome: lwOpts.PulumiHome,

@metral metral merged commit 46da254 into master Sep 3, 2020
@pulumi-bot pulumi-bot deleted the metral/autoapi-envvars branch September 3, 2020 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EvanBoyle EvanBoyle EvanBoyle approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Workspace scoped env vars
2 participants
@metral @EvanBoyle