Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(autoapi-gitrepo): use Workspace in SetupFn callback #5279

Merged
merged 1 commit into from
Sep 3, 2020

Conversation

metral
Copy link
Contributor

@metral metral commented Sep 2, 2020

Closes #5266

Copy link
Contributor

@EvanBoyle EvanBoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

Looks like the only thing left is to update the examples:

Setup: func(ctx context.Context, path string) error {

sdk/go/x/auto/local_workspace.go Outdated Show resolved Hide resolved
Copy link
Contributor

@EvanBoyle EvanBoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@metral metral merged commit dec6a6a into master Sep 3, 2020
@pulumi-bot pulumi-bot deleted the metral/autoapi-repo-setupfn branch September 3, 2020 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor GitRepo.Setup callback to pass in entire Workspace
2 participants