Revise host mode. #5317
Merged
Revise host mode. #5317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinvp
approved these changes
Sep 10, 2020
This was
linked to
issues
Sep 10, 2020
EvanBoyle
approved these changes
Sep 11, 2020
| return nil, "", err | ||
| } | ||
| if clientAddress != "" { | ||
| proj.Runtime = workspace.NewProjectRuntimeInfo("client", map[string]interface{}{ |
There was a problem hiding this comment.
I believe we rely on language info being present here for other parts of the system. I'm aware that we used this approach in the host command but I think that was an oversight.
There was a problem hiding this comment.
I'm going to leave this as-is for now and address it in a follow-up change. I'll file an issue to track.
There was a problem hiding this comment.
The current implementation of host mode uses a `pulumi host` command and an ad-hoc communication protocol between the engine and client to connect a language host after the host has begun listening. The most significant disadvantages of this approach are the communication protocol (which currently requires the use of stdout), the host-specific command, and the difficulty of accommodating the typical program-bound lifetime for an update. These changes reimplement host mode by adding engine support for connecting to an existing language runtime service rather than launching a plugin. This capability is provided via an engine-specific language runtime, `client`, which accepts the address of the existing languge runtime service as a runtime option. The CLI exposes this runtime via the `--client` flag to the `up` and `preview` commands, which similarly accepts the address of an existing language runtime service as an argument. These changes also adjust the automation API to consume the new host mode implementation.
Co-authored-by: Justin Van Patten <jvp@justinvp.com>
pgavlin
force-pushed
the
pgavlin/langClient
branch
from
a5a3925
to
5dfdab1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of host mode uses a
pulumi hostcommand andan ad-hoc communication protocol between the engine and client to
connect a language host after the host has begun listening. The most
significant disadvantages of this approach are the communication
protocol (which currently requires the use of stdout), the host-specific
command, and the difficulty of accommodating the typical program-bound
lifetime for an update.
These changes reimplement host mode by adding engine support for
connecting to an existing language runtime service rather than launching
a plugin. This capability is provided via an engine-specific language
runtime,
client, which accepts the address of the existing langugeruntime service as a runtime option. The CLI exposes this runtime via
the
--clientflag to theupandpreviewcommands, which similarlyaccepts the address of an existing language runtime service as an
argument. These changes also adjust the automation API to consume the
new host mode implementation.