Simplify types more precisely. #5440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pgavlin
added
impact/no-changelog-required
komalali
approved these changes
Sep 21, 2020
Instead of simplifying any module that ends with `/<name>`, only simplify types where `<name>` matches the type name portion after camel-casing. This continues to simplify tfbridge types like `aws:s3/bucket:Bucket`, but would not simplify a type like `aws:s3:Bucket`.
pgavlin
force-pushed
the
pgavlin/simplifyTypes
branch
from
a513e70
to
afabbe3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of simplifying any module that ends with
/<name>, only simplifytypes where
<name>matches the type name portion after camel-casing.This continues to simplify tfbridge types like
aws:s3/bucket:Bucket,but would not simplify a type like
aws:s3:Bucket.