-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Respect logging verbosity as part of pulumi plugin install #5549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaxxstorm
reviewed
Oct 12, 2020
jaxxstorm
approved these changes
Oct 12, 2020
justinvp
approved these changes
Oct 12, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM otherwise
Fixes: #4427 By default, there is no indepth logging: ``` pulumi plugin install resource azure-nextgen v0.2.1 [resource plugin azure-nextgen-0.2.1] installing Downloading plugin: 17.82 MiB / 17.82 MiB [=========================] 100.00% 2s Moving plugin... done. ``` We can increase the logging verosity get more detailed logging: ``` pulumi plugin install resource azure-nextgen v0.2.1 -v=1 --logtostderr [resource plugin azure-nextgen-0.2.1] installing I1010 19:30:58.472772 7128 plugins.go:201] azure-nextgen downloading from https://get.pulumi.com/releases/plugins Downloading plugin: 0 B / 17.82 MiB [----------------------------------] 0.00%I1010 19:30:58.704168 7128 plugin_install.go:136] [resource plugin azure-nextgen-0.2.1] installing tarball ... Downloading plugin: 17.82 MiB / 17.82 MiB [=========================] 100.00% 3s Moving plugin...I1010 19:31:01.874427 7128 plugins.go:304] moving plugin from "/Users/myuser/.pulumi/plugins/resource-azure-nextgen-v0.2.1.tmp884796935" to "/Users/myuser/.pulumi/plugins/resource-azure-nextgen-v0.2.1" done. ``` The most verbose logging level will log the request and response headers ``` pulumi plugin install resource azure-nextgen v0.2.1 -v=9 --logtostderr I1010 19:29:46.989150 7089 sink.go:146] defaultSink::Infoerr([resource plugin azure-nextgen-0.2.1] installing) [resource plugin azure-nextgen-0.2.1] installing I1010 19:29:46.989295 7089 plugins.go:591] SelectCompatiblePlugin(..., azure-nextgen): beginning I1010 19:29:46.989300 7089 plugins.go:630] SelectCompatiblePlugin(..., azure-nextgen): failed to find match I1010 19:29:46.989323 7089 plugins.go:201] azure-nextgen downloading from https://get.pulumi.com/releases/plugins I1010 19:29:46.989333 7089 plugins.go:208] full plugin download url: https://get.pulumi.com/releases/plugins/pulumi-resource-azure-nextgen-v0.2.1-darwin-amd64.tar.gz I1010 19:29:46.989360 7089 plugins.go:218] plugin install request headers: map[User-Agent:[pulumi-cli/1 (; darwin)]] I1010 19:29:47.242941 7089 plugins.go:225] plugin install response headers: map[Accept-Ranges:[bytes] Age:[370098] Content-Disposition:[attachment; filename=pulumi-resource-azure-nextgen-v0.2.1-darwin-amd64.tar.gz] Content-Length:[18684382] Content-Type:[application/x-gzip] Date:[Tue, 06 Oct 2020 11:41:30 GMT] Etag:["518f2e7efd46fe5b7be9508dc785b9c9-4"] Last-Modified:[Sat, 03 Oct 2020 20:57:45 GMT] Server:[AmazonS3] Via:[1.1 198b7d1bb217783eef010e6636984c9f.cloudfront.net (CloudFront)] X-Amz-Cf-Id:[aaC3Q0WcecspsFbWROLxXnD6iF7sYoAfShQKYiS2xkFKAWlFRBu-1Q==] X-Amz-Cf-Pop:[MAN50-C2] X-Cache:[Hit from cloudfront]] Downloading plugin: 0 B / 17.82 MiB [----------------------------------] 0.00%I1010 19:29:47.243189 7089 plugin_install.go:136] [resource plugin azure-nextgen-0.2.1] installing tarball ... Downloading plugin: 17.82 MiB / 17.82 MiB [=========================] 100.00% 2s Moving plugin...I1010 19:29:50.031099 7089 plugins.go:304] moving plugin from "/Users/myuser/.pulumi/plugins/resource-azure-nextgen-v0.2.1.tmp960784076" to "/Users/myuser/.pulumi/plugins/resource-azure-nextgen-v0.2.1" done. ```
068028b
to
d5252fa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4427
Fixes: #3609
By default, there is no indepth logging:
We can increase the logging verosity get more detailed logging:
The most verbose logging level will log the request and response headers