Support remote components in Go #5558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justinvp
force-pushed
the
justin/go_construct
branch
from
7ccbfe8
to
8ca65ab
Compare
justinvp
commented
Oct 12, 2020
justinvp
commented
Oct 12, 2020
lblackstone
approved these changes
Oct 20, 2020
There was a problem hiding this comment.
LGTM overall, but should get @pgavlin's feedback prior to merging
|
The one remaining thing I do want to get back to here is adding some more tests related to the changes to |
justinvp
force-pushed
the
justin/go_construct
branch
from
8ca65ab
to
168bc35
Compare
|
@pgavlin, this is ready for a more detailed review. I added back |
pgavlin
approved these changes
Oct 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5355