Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support python 3.9 #5669

Merged
merged 11 commits into from
Nov 4, 2020
Merged

Support python 3.9 #5669

merged 11 commits into from
Nov 4, 2020

Conversation

komalali
Copy link
Member

@komalali komalali commented Nov 3, 2020 •
edited
Loading

Fixes: #5662

komalali
komalali commented Nov 3, 2020
View reviewed changes
sdk/go/common/util/archive/archive.go
@@ -76,6 +76,7 @@ func UnTGZ(tarball []byte, dir string) error {
return errors.Wrapf(err, "untarring")
}

// nolint:gosec
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had to add this because gosec was complaining (only in CI, not locally)

@github-actions
Copy link

github-actions bot commented Nov 3, 2020

Diff for pulumi-azuread with merge commit 7c59484

@github-actions
Copy link

github-actions bot commented Nov 3, 2020

Diff for pulumi-random with merge commit 7c59484

@github-actions
Copy link

github-actions bot commented Nov 3, 2020

Diff for pulumi-kubernetes with merge commit 7c59484

@github-actions
Copy link

github-actions bot commented Nov 3, 2020

Diff for pulumi-azure with merge commit 7c59484

@github-actions
Copy link

github-actions bot commented Nov 3, 2020

Diff for pulumi-azuread with merge commit 29f76ce

@github-actions
Copy link

github-actions bot commented Nov 3, 2020

Diff for pulumi-random with merge commit 29f76ce

@github-actions
Copy link

github-actions bot commented Nov 3, 2020

Diff for pulumi-aws with merge commit 7c59484

@github-actions
Copy link

github-actions bot commented Nov 3, 2020

Diff for pulumi-kubernetes with merge commit 29f76ce

@github-actions
Copy link

github-actions bot commented Nov 3, 2020

Diff for pulumi-azure with merge commit 29f76ce

@github-actions
Copy link

github-actions bot commented Nov 3, 2020

Diff for pulumi-gcp with merge commit 7c59484

@github-actions
Copy link

github-actions bot commented Nov 3, 2020

Diff for pulumi-aws with merge commit 29f76ce

@github-actions
Copy link

github-actions bot commented Nov 3, 2020

Diff for pulumi-gcp with merge commit 29f76ce

@komalali komalali marked this pull request as ready for review November 3, 2020 19:20
@komalali komalali requested a review from stack72 November 3, 2020 19:25
@github-actions
Copy link

github-actions bot commented Nov 3, 2020

Diff for pulumi-random with merge commit a203ed8

@github-actions
Copy link

github-actions bot commented Nov 3, 2020

Diff for pulumi-azuread with merge commit a203ed8

@github-actions
Copy link

github-actions bot commented Nov 3, 2020

Diff for pulumi-kubernetes with merge commit a203ed8

@github-actions
Copy link

github-actions bot commented Nov 3, 2020

Diff for pulumi-azure with merge commit a203ed8

@github-actions
Copy link

github-actions bot commented Nov 3, 2020

Diff for pulumi-aws with merge commit a203ed8

@github-actions
Copy link

github-actions bot commented Nov 3, 2020

Diff for pulumi-gcp with merge commit a203ed8

@stack72 stack72 mentioned this pull request Nov 3, 2020
Merged
stack72
stack72 approved these changes Nov 3, 2020
View reviewed changes
Copy link
Contributor

@stack72 stack72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Subject to adding the appropriate TO-DO items with regards to supporting Python 3.9 on Windows when the package is available

@github-actions
Copy link

github-actions bot commented Nov 3, 2020

Diff for pulumi-random with merge commit 21c7bcf

@github-actions
Copy link

github-actions bot commented Nov 3, 2020

Diff for pulumi-azuread with merge commit 21c7bcf

@github-actions
Copy link

github-actions bot commented Nov 3, 2020

Diff for pulumi-kubernetes with merge commit 21c7bcf

@github-actions
Copy link

github-actions bot commented Nov 3, 2020

Diff for pulumi-azure with merge commit 21c7bcf

@github-actions
Copy link

github-actions bot commented Nov 3, 2020

Diff for pulumi-aws with merge commit 21c7bcf

@github-actions
Copy link

github-actions bot commented Nov 3, 2020

Diff for pulumi-gcp with merge commit 21c7bcf

@github-actions
Copy link

github-actions bot commented Nov 3, 2020

Diff for pulumi-random with merge commit caf5979

@github-actions
Copy link

github-actions bot commented Nov 3, 2020

Diff for pulumi-azuread with merge commit caf5979

@github-actions
Copy link

github-actions bot commented Nov 3, 2020

Diff for pulumi-kubernetes with merge commit caf5979

@github-actions
Copy link

github-actions bot commented Nov 3, 2020

Diff for pulumi-azure with merge commit caf5979

@github-actions
Copy link

github-actions bot commented Nov 3, 2020

Diff for pulumi-aws with merge commit caf5979

@github-actions
Copy link

github-actions bot commented Nov 3, 2020

Diff for pulumi-gcp with merge commit caf5979

justinvp
justinvp approved these changes Nov 3, 2020
View reviewed changes
Copy link
Member

@justinvp justinvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

.github/workflows/master.yml
@@ -25,7 +25,7 @@ jobs:
strategy:
matrix:
go-version: [ 1.15.x ]
python-version: [ 3.7.x ]
python-version: [ 3.9.x ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really a comment for this PR, but hopefully as part of #5664 we can find some way to have coverage of all the versions of Python we support (e.g. 3.6.x, 3.7.x, 3.8.x, and 3.9.x). Maybe as some cron run, and keep the matrix smaller for PRs? cc: @stack72

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I agree, I had initially run this as a matrix using [3.7.x, 3.9.x] - I think it makes sense to do that as a cron.

sdk/python/cmd/pulumi-language-python-exec Outdated Show resolved Hide resolved
@komalali @justinvp
Update sdk/python/cmd/pulumi-language-python-exec
4484007 
Co-authored-by: Justin Van Patten <jvp@justinvp.com>
@github-actions
Copy link

github-actions bot commented Nov 3, 2020

Diff for pulumi-azuread with merge commit fe8f419

@github-actions
Copy link

github-actions bot commented Nov 3, 2020

Diff for pulumi-random with merge commit fe8f419

@github-actions
Copy link

github-actions bot commented Nov 3, 2020

Diff for pulumi-kubernetes with merge commit fe8f419

@github-actions
Copy link

github-actions bot commented Nov 3, 2020

Diff for pulumi-azure with merge commit fe8f419

@github-actions
Copy link

github-actions bot commented Nov 3, 2020

Diff for pulumi-aws with merge commit fe8f419

@github-actions
Copy link

github-actions bot commented Nov 3, 2020

Diff for pulumi-gcp with merge commit fe8f419

@komalali komalali merged commit f1f6a12 into master Nov 4, 2020
@komalali komalali deleted the komalali/supportpy39 branch November 4, 2020 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stack72 stack72 stack72 approved these changes

@justinvp justinvp justinvp approved these changes

@lblackstone lblackstone lblackstone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support Python 3.9
4 participants
@komalali @stack72 @justinvp @lblackstone