Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure pulumi history marks secrets that can't be un-encrypted as such #5701

Merged
merged 2 commits into from
Nov 6, 2020

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Nov 6, 2020

This changes this:

▶ pulumi stack history --json --show-secrets
error: bad value

to this

▶ pulumi stack history --json --show-secrets
[
  {
    "kind": "update",
    "startTime": "2020-11-06T00:20:16.000Z",
    "message": "",
    "environment": {
      "exec.kind": "cli"
    },
    "config": {
      "aws:region": {
        "value": "us-east-1",
        "secret": false
      },
      "history:MySecretPassword": {
        "value": "Password1234!",
        "secret": true
      }
    },
    "result": "succeeded",
    "endTime": "2020-11-06T00:20:29.000Z",
    "resourceChanges": {
      "same": 1,
      "update": 1
    }
  },
  {
    "kind": "import",
    "startTime": "2020-11-06T00:19:28.000Z",
    "message": "",
    "environment": {},
    "config": {},
    "result": "succeeded",
    "endTime": "2020-11-06T00:19:29.000Z",
    "resourceChanges": {
      "create": 0,
      "delete": 0,
      "same": 2,
      "update": 1
    }
  },
  {
    "kind": "update",
    "startTime": "2020-11-06T00:02:29.000Z",
    "message": "",
    "environment": {
      "exec.kind": "cli"
    },
    "config": {
      "aws:region": {
        "value": "us-east-1",
        "secret": false
      },
      "history:MySecretPassword": {
        "value": "ERROR_UNABLE_TO_DECRYPT",
        "secret": true
      }
    },
    "result": "succeeded",
    "endTime": "2020-11-06T00:02:43.000Z",
    "resourceChanges": {
      "create": 2
    }
  }
]

Copy link
Contributor

@EvanBoyle EvanBoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for the quick resolution on this!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants