Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix feature support checks in the Python SDK. #5702

Merged
merged 2 commits into from
Nov 6, 2020

Conversation

pgavlin
Copy link
Member

@pgavlin pgavlin commented Nov 6, 2020

The feature to check should not be hardcoded to "secrets".

Fixes #5697.

The feature to check should not be hardcoded to "secrets".

Fixes #5697.
@pgavlin pgavlin requested a review from justinvp November 6, 2020 18:23
Copy link
Member

@justinvp justinvp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stack72 stack72 merged commit f6b687e into master Nov 6, 2020
@stack72 stack72 deleted the pgavlin/pythonFeatureCheck branch November 6, 2020 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exception: cannot unmarshal output properties: unrecognized signature
3 participants