Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create a builtin provider during import. #5730

Merged
merged 3 commits into from
Nov 11, 2020
Merged

Create a builtin provider during import. #5730

merged 3 commits into from
Nov 11, 2020

Conversation

pgavlin
Copy link
Member

@pgavlin pgavlin commented Nov 11, 2020

pulumi import may otherwise fail if there are providers in the
statefile.

@pgavlin
Create a builtin provider during import.
c748742 
`pulumi import` may otherwise fail if there are providers in the
statefile.
lukehoban
lukehoban approved these changes Nov 11, 2020
View reviewed changes
Copy link
Member

@lukehoban lukehoban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one question.

Would be great to add tests that cover the 1st class providers scenario - but possibly as a follow-up if a quick fix is needed here.

pkg/resource/deploy/import.go Show resolved Hide resolved
@pgavlin pgavlin merged commit 0ec12d0 into master Nov 11, 2020
@pulumi-bot pulumi-bot deleted the pgavlin/builtinImport branch November 11, 2020 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukehoban lukehoban lukehoban approved these changes

@clstokes clstokes Awaiting requested review from clstokes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pgavlin @lukehoban