.NET: Report plugin install errors during pulumi new
#5760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikhailshilkov
approved these changes
Nov 16, 2020
There was a problem hiding this comment.
LGTM. This would also help find pulumi/pulumi-azure-nextgen#70 sooner.
justinvp
force-pushed
the
justin/new_plugininstallerr
branch
from
6c85b94
to
6ad59b1
Compare
The way `pulumi new` installs dependencies for .NET projects is slightly different from other languages. For Node.js, Python, and Go, `pulumi new` runs the appropriate command to install project dependencies (e.g. `npm install`, `pip install`, or `go mod download`). For .NET, it calls the same routine used during `preview|up` to ensure required plugins are installed. For .NET, this ends up running `dotnet build` which implicitly installs Nuget packages, builds the project, and also attempts to determine and install the needed Pulumi plugins. When this operation runs during `preview|up`, and there are failures installing a plugin, the error is logged, but deliberately not returned, because an error will be shown for missing plugins later on during the `preview|up` operation. However, during `pulumi new`, we should show any plugin install errors.
justinvp
force-pushed
the
justin/new_plugininstallerr
branch
from
6ad59b1
to
ff06aed
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way
pulumi newinstalls dependencies for .NET projects is slightly different from other languages. For Node.js, Python, and Go,pulumi newruns the appropriate command to install project dependencies (e.g.npm install,pip install, orgo mod download). For .NET, it calls the same routine used duringpreview|upto ensure required plugins are installed. For .NET, this ends up runningdotnet buildwhich implicitly installs Nuget packages, builds the project, and also attempts to determine and install the needed Pulumi plugins. When this operation runs duringpreview|up, and there are failures installing a plugin, the error is logged, but deliberately not returned, because an error will be shown for missing plugins later on during thepreview|upoperation. However, duringpulumi new, we should show any plugin install errors.Note: Plugin install failure during
pulumi newis now much less likely now on Windows with: #5759Fixes #5685