Small UX change to the output of policy violations #5773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes: #5626 It used to be: ``` Policy Violations: [advisory] aws v0.1.20200912 allowed-image-owner (demo-aws-ts-webserver-server-0: aws:ec2/instance:Instance) Check machine image is from an approved publisher. Publisher [137112412989] is not one of [self,099720109477]. ``` Notice that it was name: type We would rather this was type: name ``` Policy Violations: [advisory] aws v0.1.20200912 allowed-image-owner (aws:ec2/instance:Instance: demo-aws-ts-webserver-server-0) Check machine image is from an approved publisher. Publisher [137112412989] is not one of [self,099720109477]. ```
|
The new output looks great, thanks! |
lukehoban
approved these changes
Nov 17, 2020
justinvp
approved these changes
Nov 17, 2020
There was a problem hiding this comment.
LGTM
We're likely going to need to update tests in https://github.com/pulumi/pulumi-policy/blob/master/tests/integration/integration_test.go and https://github.com/pulumi/pulumi-policy-aws/tree/master/integration-tests that check the CLI output.
|
Thanks for that @justinvp will open an issue now and track getting those changes made! |
This was referenced Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #5626
It used to be:
Notice that it was name: type
We would rather this was type: name