[sdk/nodejs] Implement getResource in the mock monitor #5914
Conversation
Otherwise, unit tests for programs that reference resources that have been registered with `registerResourceModule` fail with unhandled exceptions.
|
@pgavlin, if the approach in this PR looks good, I'll make similar changes for Python and the other languages. |
| const tok = req.getTok(); | ||
| const inputs = deserializeProperties(req.getArgs()); | ||
|
|
||
| if (tok === "pulumi:pulumi:getResource") { |
There was a problem hiding this comment.
Presumably we are OK handling this on behalf of the user, so they don't have to implement it themselves.
If there ever was a scenario where it's interesting to allow mocking calls for "pulumi:pulumi:getResource" in the future, I could imagine updating the Mocks interface to support an optional getResource function, that we could call if it was set instead of using the implementation here.
There was a problem hiding this comment.
We should be implementing this, as it is a builtin that deals only in state that is internal to the engine.
| const tok = req.getTok(); | ||
| const inputs = deserializeProperties(req.getArgs()); | ||
|
|
||
| if (tok === "pulumi:pulumi:getResource") { |
There was a problem hiding this comment.
We should be implementing this, as it is a builtin that deals only in state that is internal to the engine.
Otherwise, unit tests for programs that reference resources that have been registered with
registerResourceModulefail with unhandled exceptions.We didn't have any existing tests for mocks for Node.js, so I added some based on the ones we have for Python, and augmented it to cover this case. The new test fails before the change to the SDK, and passes afterwards.
Part of #5832