Fix bug with ComponentResource resource refs #5949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lblackstone
force-pushed
the
lblackstone/fix-get-ref
branch
from
3bb585a
to
9fdbf44
Compare
Now that resources are serialized as refs, ComponentResources may try to unmarshal local resource refs before they are initialized during the RegisterResource step. This change avoids that issue by skipping Output marshaling for local ComponentResources during the RegisterResource step. These Outputs will be handled instead during the RegisterResourceOutputs step.
lblackstone
force-pushed
the
lblackstone/fix-get-ref
branch
from
371eabc
to
05c0439
Compare
lblackstone
changed the title
pgavlin
reviewed
Dec 17, 2020
pgavlin
approved these changes
Dec 18, 2020
|
Any way we could get a simple unit test together? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that resources are serialized as refs, ComponentResources
may try to unmarshal local resource refs before they are
initialized during the RegisterResource step.
This change avoids that issue by skipping Output marshaling
for local ComponentResources during the RegisterResource step.
These Outputs will be handled instead during the
RegisterResourceOutputs step.
Fix #5940