Improve resource ref unit tests. #5960
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add component ref coverage to the existing test - Add coverage for a downlevel SDK communicating with an engine that supports resource refs - Add coverage for a downlevel engine communicating with an SDK that supports resource refs As part of improving coverage, these changes add a knob to explicitly disable resource refs in the engine without the use of the environment variable. The environment variable is now only read by the CLI. Contributes to #5943.
|
Ping. I'd love to get these changes in ASAP to unblock other testing. |
leezen
reviewed
Dec 16, 2020
leezen
approved these changes
Dec 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
supports resource refs
supports resource refs
As part of improving coverage, these changes add a knob to explicitly
disable resource refs in the engine without the use of the environment
variable. The environment variable is now only read by the CLI.
I believe that these changes also fix #5939, which I needed to
address in order for the tests to pass.
Contributes to #5943.