Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix panic related to update with refresh #5980

Merged
merged 1 commit into from
Dec 19, 2020
Merged

Fix panic related to update with refresh #5980

merged 1 commit into from
Dec 19, 2020

Conversation

lblackstone
Copy link
Member

Fix #5946

@lblackstone lblackstone marked this pull request as ready for review December 18, 2020 22:22
@lblackstone lblackstone force-pushed the lblackstone/fix-refresh-panic branch 2 times, most recently from 1eb903f to ad95c57 Compare December 18, 2020 22:25
@lblackstone
Fix panic related to update with refresh
5bf267e 
The step generator was incorrectly tracking goal states for
old resources, which could lead to a panic if the resource
was removed in the update. This fix only generates goal
states for resources that exist in the updated program.
@lblackstone
Copy link
Member Author

@pgavlin If this looks good, feel free to merge.

@pgavlin pgavlin merged commit 8a9b381 into master Dec 19, 2020
@pulumi-bot pulumi-bot deleted the lblackstone/fix-refresh-panic branch December 19, 2020 07:03
@lukehoban lukehoban mentioned this pull request Dec 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pgavlin pgavlin pgavlin left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Panic with pulumi up when using refresh
2 participants
@lblackstone @pgavlin