Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix virtual env path #5992

Merged
merged 2 commits into from
Dec 22, 2020
Merged

Fix virtual env path #5992

merged 2 commits into from
Dec 22, 2020

Conversation

komalali
Copy link
Member

There was a regression introduced in #5787 that causes the venv for the policy pack to not be created correctly. This PR fixes the regression.

Fixes: pulumi/pulumi-policy#262

@komalali komalali merged commit d0676c1 into master Dec 22, 2020
@komalali komalali deleted the komalali/fix-py-policy-pack branch December 22, 2020 01:46
Copy link
Member

@lukehoban lukehoban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix looks good. Is there a test case we could add that would ensure this is working?

@komalali
Copy link
Member Author

@lukehoban We could test this by publishing a python policy pack and applying it to one or more of our test stacks.

@lukehoban
Copy link
Member

@lukehoban We could test this by publishing a python policy pack and applying it to one or more of our test stacks.

FWIW - looks like we should address these to ensure we have coverage here (which would likely have caught this regression):

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

venv not created for pack from Pulumi organization
3 participants