gRPC bridge: fix unknowns in Update previews
#6006
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These changes add support for communicating with providers using the gRPC adapters to the deploytest pacakage. This makes it easier to test the gRPC adapters across typical lifecycle patterns. Supporting these changes are two additions to the `resource/plugin` package: 1. A type that bridges between the `plugin.Provider` interface and the `pulumirpc.ResourceProviderServer` 2. A function to create a `plugin.Provider` given a `pulumirpc.ResourceProviderClient` The deploytest package uses these to wrap an in-process `plugin.Provider` in a gRPC interface and connect to it without using the default plugin host, respectively.
Add a test that runs the provider preview lifecycle, but using a provider that communicates over gRPC.
Set the `KeepUnknowns` and `RejectUnknowns` bits in the `MarshalOptions` used when unmarshaling update results to preserve unknowns during a preview and reject them otherwise. These changes also set the `RejectUnknowns` bit in the `MarshalOptions` used by `Create` if `preview` is false, and fix a bug in the array unmarshaler that could cause out-of-bounds accesses.
pgavlin
force-pushed
the
pgavlin/updatePreview
branch
from
248aa46
to
d0f0ca4
Compare
|
regarding "deploytest: add support for gRPC adapters": my plan is to update the testing targets s.t. we run all of the tests in the lifecycle harness with and without the gRPC adapter except for those that explicitly opt out. I opted to skip that for now in order to deliver a more targeted test for the issue at hand. |
lblackstone
reviewed
Dec 23, 2020
lblackstone
approved these changes
Dec 23, 2020
I did add support for a command-line flag that enables the gRPC adapter for all of the tests, however. This should let us work on fixing them one-by-one. |
|
( I think that this fixes #6004) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are a combination of three commits, each of which
contributes to the testing and/or fixing of a problem with marshaling
unknowns in
plugin.provider.Updatewhenpreviewis true.deploytest: add support for gRPC adapters.
These changes add support for communicating with providers using the
gRPC adapters to the deploytest pacakage. This makes it easier to test
the gRPC adapters across typical lifecycle patterns.
Supporting these changes are two additions to the
resource/pluginpackage:
plugin.Providerinterface and thepulumirpc.ResourceProviderServerplugin.Providergiven apulumirpc.ResourceProviderClientThe deploytest package uses these to wrap an in-process
plugin.Providerin a gRPC interface and connect to it without usingthe default plugin host, respectively.
pulumi_test: test provider preview over gRPC.
Add a test that runs the provider preview lifecycle, but using a
provider that communicates over gRPC.
gRPC bridge: fix unknowns in
UpdatepreviewsSet the
KeepUnknownsandRejectUnknownsbits in theMarshalOptionsused when unmarshaling update results to preserve unknowns during a
preview and reject them otherwise.
These changes also set the
RejectUnknownsbit in theMarshalOptionsused by
Createifpreviewis false, and fix a bug in the arrayunmarshaler that could cause out-of-bounds accesses.
Fixes #6004.