Allow serializeFunction to capture secrets
#6013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an opt-in `allowSecrets` flag to `serializeFunction` to allow it to capture secrets. If passed, `serializeFunction` will now report back whether it captured any secrets. This information can be used by callers to wrap the resulting text in a Secret value. Fixes #2718.
lukehoban
added a commit
to pulumi/pulumi-aws
that referenced
this pull request
Dec 26, 2020
Opts-in to the secret capture support added in pulumi/pulumi#6013.
lukehoban
added a commit
to pulumi/pulumi-aws
that referenced
this pull request
Dec 26, 2020
Opts-in to the secret capture support added in pulumi/pulumi#6013.
lukehoban
added a commit
to pulumi/pulumi-azure
that referenced
this pull request
Dec 26, 2020
Opts-in to the secret capture support added in pulumi/pulumi#6013. Part of pulumi/pulumi#2718.
stack72
approved these changes
Dec 30, 2020
lukehoban
added a commit
to pulumi/pulumi-azure
that referenced
this pull request
Jan 7, 2021
Opts-in to the secret capture support added in pulumi/pulumi#6013. Part of pulumi/pulumi#2718.
lukehoban
added a commit
to pulumi/pulumi-aws
that referenced
this pull request
Jan 7, 2021
Opts-in to the secret capture support added in pulumi/pulumi#6013.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an opt-in
allowSecretsflag toserializeFunctionto allow it to capture secrets. If passed,serializeFunctionwill now report back whether it captured any secrets. This information can be used by callers to wrap the resulting text in a Secret value.Fixes #2718.