-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow VERSION to be set explicitly #6016
Conversation
I've been doing some work on the alpine build script today and this patch isn't quite right. I'll do some more testing and get back to this once I've sorted the alpine build out. |
When building for alpine aports we download the pulumi source from a github archive (e.g. https://github.com/pulumi/pulumi/archive/v2.16.0.tar.gz) but this doesn't include the .git information to allow scripts/get-version to work. This patch, which is currently applied on top of the base pulumi code as part of the alpine build (see [1]), simply allows the alpine build script to explicitly set the version used. In the alpine build script this always matches the source code archive version to download. [1] https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/16281
671a7b1
to
f0600e3
Compare
I've now updated this for the latest version of what I'm using in the alpine pipeline (Still waiting for the merge request to be merged in aports). |
This patch is now merged on the alpine side. I've got one more large change to the alpine pipeline to get it working properly and the only patch needed to the base pulumi code for that pipeline is what's in this PR. |
/run-acceptance-tests |
Please view the results of the PR Build + Acceptance Tests Run Here |
Thanks so much for this @Frassle I was able to get the correct behaviour here:
I just kicked off a set of acceptance tests to ensure our build process works as expected and will merge on a green build! Thanks again Paul |
Please view the results of the PR Build + Acceptance Tests Run Here |
When building for alpine aports we download the pulumi source from a
github archive (e.g.
https://github.com/pulumi/pulumi/archive/v2.16.0.tar.gz) but this
doesn't include the .git information to allow scripts/get-version to
work.
This patch, which is currently applied on top of the base pulumi
code as part of the alpine build (see [1]), simply allows the alpine
build script to explicitly set the version used. In the alpine build
script this always matches the source code archive version to download.
[1] https://gitlab.alpinelinux.org/alpine/aports/-/merge_requests/16281