Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow optional strict enum types to be omitted #6069

Merged
merged 4 commits into from
Jan 11, 2021
Merged

Conversation

viveklak
Copy link
Contributor

@viveklak viveklak commented Jan 8, 2021

Fixes #6068

@github-actions
Copy link

github-actions bot commented Jan 8, 2021

Diff for pulumi-random with merge commit ba411d0

@github-actions
Copy link

github-actions bot commented Jan 8, 2021

Diff for pulumi-kubernetes with merge commit ba411d0

@github-actions
Copy link

github-actions bot commented Jan 8, 2021

Diff for pulumi-azuread with merge commit ba411d0

@github-actions
Copy link

github-actions bot commented Jan 8, 2021

Diff for pulumi-gcp with merge commit ba411d0

@github-actions
Copy link

github-actions bot commented Jan 8, 2021

Diff for pulumi-random with merge commit 09c1b48

@github-actions
Copy link

github-actions bot commented Jan 8, 2021

Diff for pulumi-azuread with merge commit 09c1b48

@github-actions
Copy link

github-actions bot commented Jan 8, 2021

Diff for pulumi-kubernetes with merge commit 09c1b48

@github-actions
Copy link

github-actions bot commented Jan 8, 2021

Diff for pulumi-azure with merge commit ba411d0

@github-actions
Copy link

github-actions bot commented Jan 8, 2021

Diff for pulumi-aws with merge commit ba411d0

@github-actions
Copy link

github-actions bot commented Jan 8, 2021

Diff for pulumi-gcp with merge commit 09c1b48

@github-actions
Copy link

github-actions bot commented Jan 8, 2021

Diff for pulumi-azure with merge commit 09c1b48

@github-actions
Copy link

github-actions bot commented Jan 8, 2021

Diff for pulumi-aws with merge commit 09c1b48

@github-actions
Copy link

github-actions bot commented Jan 8, 2021

Diff for pulumi-random with merge commit 2fd5a42

@github-actions
Copy link

github-actions bot commented Jan 8, 2021

Diff for pulumi-azuread with merge commit 2fd5a42

@github-actions
Copy link

github-actions bot commented Jan 8, 2021

Diff for pulumi-kubernetes with merge commit 2fd5a42

@github-actions
Copy link

github-actions bot commented Jan 8, 2021

Diff for pulumi-gcp with merge commit 2fd5a42

@github-actions
Copy link

github-actions bot commented Jan 8, 2021

Diff for pulumi-azure with merge commit 2fd5a42

@github-actions
Copy link

github-actions bot commented Jan 8, 2021

Diff for pulumi-aws with merge commit 2fd5a42

Copy link
Member

@mikhailshilkov mikhailshilkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@@ -276,8 +276,12 @@ func (pkg *pkgContext) inputType(t schema.Type, optional bool) string {
var typ string
switch t := t.(type) {
case *schema.EnumType:
var enumType string
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: enumType doesn't feel like an obvious name. Is it more of a modifier thing, or prefix, or nullable?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@github-actions
Copy link

Diff for pulumi-random with merge commit 7a745cb

@github-actions
Copy link

Diff for pulumi-azuread with merge commit 7a745cb

@github-actions
Copy link

Diff for pulumi-kubernetes with merge commit 7a745cb

@github-actions
Copy link

Diff for pulumi-gcp with merge commit 7a745cb

@github-actions
Copy link

Diff for pulumi-azure with merge commit 7a745cb

@github-actions
Copy link

Diff for pulumi-aws with merge commit 7a745cb

@viveklak viveklak merged commit 0d4f886 into master Jan 11, 2021
@pulumi-bot pulumi-bot deleted the vl/OptionalStrictEnum branch January 11, 2021 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[sdk/go] Not possible to omit optional enum properties
3 participants