-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow optional strict enum types to be omitted #6069
Conversation
Diff for pulumi-random with merge commit ba411d0 |
Diff for pulumi-kubernetes with merge commit ba411d0 |
Diff for pulumi-azuread with merge commit ba411d0 |
Diff for pulumi-gcp with merge commit ba411d0 |
Diff for pulumi-random with merge commit 09c1b48 |
Diff for pulumi-azuread with merge commit 09c1b48 |
Diff for pulumi-kubernetes with merge commit 09c1b48 |
Diff for pulumi-azure with merge commit ba411d0 |
Diff for pulumi-aws with merge commit ba411d0 |
Diff for pulumi-gcp with merge commit 09c1b48 |
Diff for pulumi-azure with merge commit 09c1b48 |
Diff for pulumi-aws with merge commit 09c1b48 |
Diff for pulumi-random with merge commit 2fd5a42 |
Diff for pulumi-azuread with merge commit 2fd5a42 |
Diff for pulumi-kubernetes with merge commit 2fd5a42 |
Diff for pulumi-gcp with merge commit 2fd5a42 |
Diff for pulumi-azure with merge commit 2fd5a42 |
Diff for pulumi-aws with merge commit 2fd5a42 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
pkg/codegen/go/gen.go
Outdated
@@ -276,8 +276,12 @@ func (pkg *pkgContext) inputType(t schema.Type, optional bool) string { | |||
var typ string | |||
switch t := t.(type) { | |||
case *schema.EnumType: | |||
var enumType string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: enumType
doesn't feel like an obvious name. Is it more of a modifier
thing, or prefix
, or nullable
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed.
19805f6
to
15f9fb3
Compare
Diff for pulumi-random with merge commit 7a745cb |
Diff for pulumi-azuread with merge commit 7a745cb |
Diff for pulumi-kubernetes with merge commit 7a745cb |
Diff for pulumi-gcp with merge commit 7a745cb |
Diff for pulumi-azure with merge commit 7a745cb |
Diff for pulumi-aws with merge commit 7a745cb |
Fixes #6068